build: Clarify buildType #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the meaning of buildType, as it was unclear. The actual intent was to "namespace" the meaning of a Build element so that the rest of the properties can be interpreted. This matches the SLSA definition of buildType.
bact
requested changes
Sep 4, 2024
| * An invocation of a compiler or other tool | ||
| * A script that orchestrates builds at a higher level | ||
|
|
||
| Keep in mind that builds can be "nested" using the `ancestorOf` relationship |
There was a problem hiding this comment.
Suggested change
| Keep in mind that builds can be "nested" using the `ancestorOf` relationship | |
| Keep in mind that builds can be "nested" using the `ancestorOf` relationship. |
|
|
||
| If the buildType IRI is not recognized, it is still possible to inspect other | ||
| properties of the build, but it may not be possible to derive deeper meaning | ||
| from them |
There was a problem hiding this comment.
Suggested change
| from them | |
| from them. |
| properties of the build, but it may not be possible to derive deeper meaning | ||
| from them | ||
|
|
||
| For more information, see the SLSA definition of buildType |
There was a problem hiding this comment.
Suggested change
| For more information, see the SLSA definition of buildType | |
| For more information, see the SLSA definition of buildType. |
|
Note: after this PR got merged, need to add ref to SLSA in the Reference chapter: -- SLSA ref was in the Reference before, but was removed by spdx/spdx-spec#1076 as with the merged of #862 there's no citation to SLSA in both spdx-3-model and spdx-spec. The text we were previously used: *SLSA Provenance v0.2*, The Linux Foundation,
[https://slsa.dev/provenance/v0.2](https://slsa.dev/provenance/v0.2).It was between refs to "Semantic Versioning" and "SoftWare Heritage". |
|
@kestewart @goneall should this update be in 3.0.1 or 3.1 ? |
|
I would like to get this reviewed by Nisha and Brandon - I'll ping them in email. |
lumjjb
approved these changes
Sep 10, 2024
kestewart
approved these changes
Sep 10, 2024
bact
added a commit
to bact/spdx-spec
that referenced
this pull request
Sep 10, 2024
SLSA reintroduced because of spdx/spdx-3-model#875 Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
The bullet is broken, will be fixed by this PR #879 |
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the meaning of buildType, as it was unclear. The actual intent was to "namespace" the meaning of a Build element so that the rest of the properties can be interpreted. This matches the SLSA definition of buildType.